Fix HC3 compatibility further #38931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further fixes for HC3 compatibility.
probot-home-assistant
bot
added
bugfix
code-quality
integration: fibaro
small-pr
MartinHjelmare
changed the title
MartinHjelmare
requested changes
Aug 16, 2020
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
balloob
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Update __init__.py Further fixes for HC3 compatibility. * Update homeassistant/components/fibaro/__init__.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Merged
|
Hello @pbalogh77. I have changed from Fibaro HC2 to HC3 and the Fibaro HA integration does not work by providing the local IP of the fibaro. Could you pls let me know if the HC3 is still supported or I may do something wrong? Thanks |
|
Please open an issue instead. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fixes for HC3 compatibility.
Proposed change
Sometimes the new Fibaro HC3 misses important fields for scenes. Making sure such event does not result in a crash of the integration.
Type of change
Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests
This PR fixes or closes issue: fixes
This PR is related to issue: Fibaro Integration with HC3 #38373
Link to documentation pull request:
Checklist
black --fast homeassistant tests)To help with the load of incoming pull requests: